Mark callback binding cop as unsafe and disable it by default #81
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
mark_callback_cop_as_unsafe
branch
from
ea9f8a7 to
ebe2705
Compare
paracycle
approved these changes
Oct 21, 2021
Co-authored-by: Ufuk Kayserilioglu <[email protected]>
Morriar
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback binding cop has an unsafe auto-correct, since some libraries define similar style callbacks using the same names as Rails, but that need different types of bindings. This can lead to false positives and introduce typing errors when running auto-correct.
This PR just disables the cop by default, marks it as unsafe and adds a note about why in the documentation.