Update index enhancement due to ruby-lsp changes #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Oct 26, 2024
andyw8
force-pushed
the
andyw8/update-index-enhancement
branch
from
026aa4b to
1b85c99
Compare
andyw8
force-pushed
the
andyw8/update-index-enhancement
branch
from
1b85c99 to
144a687
Compare
vinistock
approved these changes
Oct 31, 2024
Comment on lines
9
to
13
| sig { params(index: RubyIndexer::Index).void } | ||
| def initialize(index) | ||
| super | ||
| @index = index | ||
| end |
There was a problem hiding this comment.
We don't need to override initialize. This is already the same in the parent class.
There was a problem hiding this comment.
I had tried that but it fails with:
lib/ruby_lsp/ruby_lsp_rails/indexing_enhancement.rb:64: Use of undeclared variable @index https://srb.help/6002
64 | @index.add(RubyIndexer::Entry::Method.new(
So I expect we'll need to fix ruby-lsp to use a T.let?
There was a problem hiding this comment.
Ah, I see. You can add a shim to inform Sorbet about the T.let.
andyw8
force-pushed
the
andyw8/update-index-enhancement
branch
from
6c51b64 to
4d4085c
Compare
vinistock
approved these changes
Oct 31, 2024
andyw8
force-pushed
the
andyw8/update-index-enhancement
branch
from
4d4085c to
6698760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Shopify/ruby-lsp#2754