Show progress when reloading the Rails application #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
01-28-show_progress_when_reloading_the_rails_application
branch
from
961dce2 to
3bee158
Compare
andyw8
reviewed
Jan 28, 2025
andyw8
approved these changes
Jan 28, 2025
vinistock
force-pushed
the
01-28-show_progress_when_reloading_the_rails_application
branch
from
3bee158 to
e034155
Compare
vinistock
deleted the
01-28-show_progress_when_reloading_the_rails_application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the slowest parts of DSL RBI generation in the Tapioca add-on is actually the fact that we're reloading the Rails app.
In addition to adding progress notifications there, let's also show the progress of reloading the app, so that the user knows what's going on.