Apply suggestions from code review

- Add test using hash with slightly more complex formatting - Cleanup Co-authored-by: Alexandre Terrasa <[email protected]> Co-authored-by: Vinicius Stock <[email protected]>
Shopify · Nov 21, 2023 · 3d44258 · 3d44258
1 parent d98cbcf
commit 3d44258
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 3 deletions.
diff --git a/lib/ruby_lsp/requests/inlay_hints.rb b/lib/ruby_lsp/requests/inlay_hints.rb
@@ -27,7 +27,7 @@ module Requests
     #   var: var, # Label "var" goes here in cases where the value is omitted
     #   a: "hello",
     # }
-    # `
+    # ```
     class InlayHints < Listener
       extend T::Sig
       extend T::Generic
@@ -46,8 +46,7 @@ def initialize(range, dispatcher, message_queue)
         @_response = T.let([], ResponseType)
         @range = range
 
-        dispatcher.register(self, :on_rescue_node_enter)
-        dispatcher.register(self, :on_implicit_node_enter)
+        dispatcher.register(self, :on_rescue_node_enter, :on_implicit_node_enter)
       end
 
       sig { params(node: Prism::RescueNode).void }

diff --git a/test/expectations/inlay_hints/hash_literal_omitted_values.exp.json b/test/expectations/inlay_hints/hash_literal_omitted_values.exp.json
@@ -53,6 +53,24 @@
       "label": "hello",
       "tooltip": "This is a local variable: hello",
       "paddingLeft": true
+    },
+    {
+      "position": {
+        "line": 14,
+        "character": 8
+      },
+      "label": "foo",
+      "tooltip": "This is a method call. Method name: foo",
+      "paddingLeft": true
+    },
+    {
+      "position": {
+        "line": 16,
+        "character": 9
+      },
+      "label": "TEST",
+      "tooltip": "This is a constant: TEST",
+      "paddingLeft": true
     }
   ]
 }
diff --git a/test/fixtures/hash_literal_omitted_values.rb b/test/fixtures/hash_literal_omitted_values.rb
@@ -10,4 +10,10 @@ def foo; end
 
   def test(opts = {}); end
   test(foo:, TEST:, hello:)
+
+  {
+    foo:,
+    bar: "bar",
+    TEST:,
+  }
 end