-
Notifications
You must be signed in to change notification settings - Fork 176
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return early if magic source link URI has no path (#3056)
### Motivation This error was caught by our telemetry. If someone is manually typing a magic source link or if there's some error in Tapioca's generation, then the URI's path might be `nil`, which then fails when we pass it to `CGI.unescape` with a `no implicit conversion of nil to String`. ### Implementation Started checking if there's a path before trying to unescape it. ### Automated Tests Added a test that fails in main.
- Loading branch information
Showing
2 changed files
with
23 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters