Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully adopt the new response builder pattern and remove the Listener class #1337

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Fully adopt the new response builder pattern and remove the Listener class #1337

merged 9 commits into from
Jan 30, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jan 29, 2024

Motivation

After adopting the response builder pattern in extensible requests, we currently have 3 types of requests:

  1. Not listener-based
  2. (Legacy) Listener-class-based listeners
  3. PORO (plain old Ruby object) listeners

While we think it's fine to cut a release first, I found that it's actually not that hard to eliminate 2 completely.

Implementation

  • I adopted the new pattern in the remaining requests with dedicated commits:
    • Completion
    • DocumentHighlight
    • DocumentLink
    • FoldingRanges
    • InlayHints
    • SignatureHelp
  • Then I removed the Listener class completely
  • Finally, I also updated the messages in the check_docs task

Automated Tests

Manual Tests

@st0012 st0012 added the chore Chore task label Jan 29, 2024
@st0012 st0012 self-assigned this Jan 29, 2024
@st0012 st0012 requested a review from a team as a code owner January 29, 2024 21:37
@st0012 st0012 requested review from andyw8 and Morriar January 29, 2024 21:37
@st0012 st0012 force-pushed the deprecate-listener branch from d373d56 to 12765af Compare January 29, 2024 21:43
@st0012 st0012 added breaking-change Non-backward compatible change and removed chore Chore task labels Jan 29, 2024
@st0012 st0012 force-pushed the deprecate-listener branch from 12765af to d6bd600 Compare January 30, 2024 10:18
@st0012 st0012 requested a review from vinistock January 30, 2024 17:16
vinistock
vinistock approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

lib/ruby_lsp/response_builders/collection_response_builder.rb Outdated Show resolved Hide resolved
@st0012 st0012 force-pushed the deprecate-listener branch from a358606 to 2c2985c Compare January 30, 2024 21:50
@st0012 st0012 merged commit 06fa0e6 into main Jan 30, 2024
30 checks passed
@st0012 st0012 deleted the deprecate-listener branch January 30, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@andyw8 andyw8 Awaiting requested review from andyw8 andyw8 was automatically assigned from Shopify/ruby-dev-exp

@Morriar Morriar Awaiting requested review from Morriar Morriar was automatically assigned from Shopify/ruby-dev-exp

@aryan-soni aryan-soni Awaiting requested review from aryan-soni

Assignees

@st0012 st0012

Labels
breaking-change Non-backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @vinistock