-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DocumentLink request #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Jul 14, 2022
Morriar
reviewed
Jul 14, 2022
st0012
force-pushed
the
support-document-link
branch
2 times, most recently
from
July 26, 2022 10:03
777097a
to
4d8f6ba
Compare
This PR looks almost ready to go for us all to enjoy jumping to gem source from RBIs. Can we please finalize the request documentation? |
This request uses the gem source comments generated by Tapioca to let users quickly jump to the actual source of the definition.
Co-authored-by: Alexandre Terrasa <[email protected]> Co-authored-by: Vinicius Stock <[email protected]> Co-authored-by: Stan Lo <[email protected]> Co-authored-by: Maple Ong <[email protected]> Co-authored-by: Adison Lampert <[email protected]> Co-authored-by: Emily Giurleo <[email protected]>
st0012
force-pushed
the
support-document-link
branch
from
July 26, 2022 18:04
4d8f6ba
to
91fd038
Compare
st0012
force-pushed
the
support-document-link
branch
from
July 26, 2022 19:58
aeaab14
to
9ec0495
Compare
vinistock
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Morriar
approved these changes
Jul 27, 2022
Co-authored-by: Alexandre Terrasa <[email protected]>
vinistock
pushed a commit
that referenced
this pull request
Aug 12, 2022
Support DocumentLink request
andyw8
pushed a commit
to andyw8/ruby-lsp
that referenced
this pull request
Mar 2, 2024
…sbuild-0.15.5 Bump esbuild from 0.15.3 to 0.15.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This request uses the gem source comments generated by Tapioca to let users quickly jump to the actual source of the definition.
Implementation
Add a new
DocumentLink
request to detect# source://PATH_TO_FILE:line
comments and return clickable links if the file exists.Automated Tests
New expectation + integration test cases.
Manual Tests
vscode-ruby-lsp
extension from the PRbundle exec tapioca gem
to make sure we have rbi files that have the new source comments# source://PATH_TO_FILE:line
comments and hover the mouse over one of themJump to PATH_TO_FILE#line
in the tooltipDemo