Handle US_ASCII encoding when parsing rails application config
#2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Aug 20, 2024
| @@ -289,6 +289,7 @@ def rails_app? | |||
| application_contents = config.read if config.exist? | |||
| return false unless application_contents | |||
|
|
|||
| application_contents = application_contents.encode(Encoding::UTF_8, Encoding::UTF_8, invalid: :replace) | |||
There was a problem hiding this comment.
force_encoding would do the job as well but this is more robust against whatever else may be present in that file
Earlopain
force-pushed
the
rails-app-us-ascii
branch
6 times, most recently
from
27fb72d to
d0c4d02
Compare
Earlopain
force-pushed
the
rails-app-us-ascii
branch
from
d0c4d02 to
f3e512d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Connects to #2463
Implementation
Added ascii encoding tests to the CI pipeline. Surprisingly to me, this was the only test that failed (and some multibyte which make less sense for
US_ASCIIencoding).Not that knowledgable on this encoding stuff, but I do know that if ruby gets run with proper
LANGenvironment variables,Encoding.default_externalwill reflect that which then causesFile.readand the like to also read files in that encoding.Could in theory force the encoding by overwriting
Encoding.default_externalbut however the user has set this up, there is probably a reason for it.Automated Tests
Run the test suite with a encoding different to utf8.
Manual Tests
None, I'm not really sure how ):. I did at least confirm that this doesn't break when the encoding is utf8.