Delete comment prefix when lazy fetching #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
vinistock
force-pushed
the
vs-delete-comment-prefix-when-lazy-fetching
branch
from
f01e8fc to
e86cf3b
Compare
andyw8
approved these changes
Sep 20, 2024
vinistock
force-pushed
the
vs-delete-comment-prefix-when-lazy-fetching
branch
from
e86cf3b to
e704977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2582
I forgot to delete the leading
#and possible blank space when we're fetching comments lazily. Since the documentation is rendered as markdown, it makes everything appear ash1tags, which are huge.Implementation
Just added the prefix delete, exactly like we do in eager comment fetching.
Automated Tests
Added a test to ensure we don't regress.