Collect inlay hints during combined requests #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
force-pushed
the
vs-run-inlay-hint-with-combined-requests
branch
from
49bc151 to
984948f
Compare
andyw8
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should be collecting and caching inlay hints as part our combined requests. That way, we only perform the work once per document state and if the user keeps scrolling the document, we just filter the ones to show based on the given range.
This prevents another AST traversal and improves our performance on user edits.
Implementation
The idea is to collect and cache inlay hints during the combined requests, but we still keep the request itself separate so that we can apply the range if user is scrolling up and down.
Automated Tests
Current tests should cover it.