Fix: Block parameters prefixed with underscore are incorrectly highlighted #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: Removes the distinction between block variables prefixed with underscore and those not prefixed with underscore. Why: As per the github issue: the leading underscore is just a convention. From Ruby's perspective, it's still a parameter and even referring to it still works.
|
|
vinistock
added
bugfix
vinistock
deleted the
willyam-fix-block-params-prefixed-with-underscore
branch
andyw8
changed the title
|
(I changed the PR title so the changelog for the next release is easier to read) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2837
What:
Removes the distinction between block variables prefixed with underscore and those not prefixed with underscore.
Why:
As per the github issue: the leading underscore is just a convention. From Ruby's perspective, it's still a parameter and even referring to it still works.
Implementation
The regex was making 3 capture groups, one of which was specifically for variables prefixed with an underescore. I removed that group and modified the other variable group to include the underscore prefix.
Automated Tests
I saw there was
grammars.test.tsbut I'm running into a lot of errors trying to run the tests. It's a work in progressManual Tests
With changes
ges:
Without changes:
