Handle missing specs when listing transitive dependencies #3012
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
st0012
approved these changes
Jan 6, 2025
andyw8
approved these changes
Jan 6, 2025
vinistock
force-pushed
the
01-06-handle_missing_specs_when_listing_transitive_dependencies
branch
from
394fbf1 to
e4fbeea
Compare
Merge activity
|
vinistock
deleted the
01-06-handle_missing_specs_when_listing_transitive_dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a mistake made in #2937. We cannot invoke
to_specwithout rescuingGem::MissingSpecErrorbecause that gets raised whenever there's a gem that doesn't match platform constraints.Implementation
Added the missing rescue.
Automated Tests
Added a test that fails before the fix so that we catch this next time.