Only load install error instance after requiring Bundler #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
st0012
approved these changes
Jan 10, 2025
Merge activity
|
vinistock
deleted the
01-10-only_load_install_error_instance_after_requiring_bundler
branch
|
@vinistock Does this look like something which would be fixed once this is released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3038, closes #3042
I made a mistake in #3033. We cannot invoke
Marshal.loadbefore requiring Bundler, because then the error classes that we're trying to load will not be defined.Implementation
Moved the
install_errorhandling after requiring Bundler and ensured that the local variable is available within scope for instantiating the server at the end of the file.