Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace interpolated string pattern with regexp #3058

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Replace interpolated string pattern with regexp #3058

merged 2 commits into from
Jan 13, 2025

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jan 13, 2025

Motivation

To suppress this warning: Unexpected template string expression

Implementation

Use regexp instead.

Automated Tests

Manual Tests

@st0012 st0012 added chore Chore task vscode This pull request should be included in the VS Code extension's release notes labels Jan 13, 2025
@st0012 st0012 requested a review from a team as a code owner January 13, 2025 15:42
paracycle
paracycle reviewed Jan 13, 2025
View reviewed changes
vscode/src/rubyLsp.ts Outdated Show resolved Hide resolved
@st0012 @paracycle
Update vscode/src/rubyLsp.ts
ac287b7 
Co-authored-by: Ufuk Kayserilioglu <[email protected]>
@st0012 st0012 merged commit 4b32e6c into main Jan 13, 2025
42 checks passed
@st0012 st0012 deleted the properly-escape-interpolation-like-strings branch January 13, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

Assignees
No one assigned
Labels
chore Chore task vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @paracycle