Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add highlight for do...end blocks #3061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vicocamacho
Copy link

@vicocamacho vicocamacho commented Jan 13, 2025

Motivation

Closes #2929

As I was investigating the problem with the issue above I discovered that the highlight functionality for do blocks was not implemented.

Implementation

This PR enhances the existing Highlight feature to add support for highlighting blocks.

Automated Tests

Added new expectations using the existing "do block" fixture files.

Manual Tests

Go to the start of a do block, it should highlight its matching end

@vicocamacho vicocamacho requested a review from a team as a code owner January 13, 2025 20:13
@vicocamacho
Copy link
Author

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight block correctly in ERB file
1 participant