Prevent double activation when multiple documents are opened #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
vscode
Graphite App
KaanOzkan
approved these changes
Jan 16, 2025
Merge activity
|
vinistock
deleted the
01-15-prevent_double_activation_when_multiple_documents_are_opened
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we started preventing double activation on lazy activations #2693, I forgot to do the same for when the user starts the editor with multiple documents opened.
Implementation
We need to remember that we're already activating the workspace, so that we don't accidentally launch multiple duplicates for the same folder.