Include thread-safety rubocop #703
Draft
+68
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
config change
alexpark20
force-pushed
the
thread-safety-rubocop
branch
2 times, most recently
from
3999c6e to
5ab601c
Compare
rafaelfranca
requested changes
Mar 6, 2025
test/fixtures/full_config.yml
Outdated
| ThreadSafety/NewThread: | ||
| Description: Avoid starting new threads. Let a framework like Sidekiq handle the | ||
| threads. | ||
| Enabled: true |
There was a problem hiding this comment.
Right, we are not enabling it on SFR too. I will disable it 👍
rafaelfranca
reviewed
Mar 6, 2025
test/fixtures/full_config.yml
Outdated
| Enabled: true | ||
| ThreadSafety/MutableClassInstanceVariable: | ||
| Description: Do not assign mutable objects to class instance variables. | ||
| Enabled: true |
There was a problem hiding this comment.
This cop is disallowing:
class FooTest < ActiveSupport::TestCase
setup do
@something = { a: "A" }
end
endWhich doesn't have any thread safety issue.
We need to fix that in order to enable it.
There was a problem hiding this comment.
I will not enable it yet. Good check, lets socialize how we can fix it 👍
alexpark20
force-pushed
the
thread-safety-rubocop
branch
2 times, most recently
from
3da3d00 to
4c2b934
Compare
alexpark20
force-pushed
the
thread-safety-rubocop
branch
from
4c2b934 to
3cd22cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.