Centralize Ruby Version to .ruby-version
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I can't run script/test or bundle exec rake due to an error. There's a change with Ruby that has been fixed in Rake 12.3.2: ruby/rake@81763da
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
3f0796f to
910ca1b
Compare
jenshenny
commented
Apr 30, 2024
alexcrocha
reviewed
May 3, 2024
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
337954e to
720096d
Compare
george-ma
approved these changes
Jun 19, 2024
alexcrocha
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
.ruby-versionfile is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-versionfile, ensures arequired_ruby_versionis set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-versionfile is present with the correct Ruby version definedrequired_ruby_versionin your gemspec is setGemfile(no lines withruby <some-version>)Gemfile.lockis built with the defined Ruby versionTargetRubyVersiondefined inrubocop.yml(reads fromrequired_ruby_versionon Rubocop 1.61.0)ruby/setup-rubyGithub Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”)To establish consistency, the
required_ruby_versionis set to 2.6. If you think that another version is a better fit, please make the applicable changes.Please merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.