Use request.remote_ip
instead of request.ip
to obtain buyer IP
#1359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a usage doc update to guide devs to accurately obtain the buyer IP using rail's
request.remote_ip
rather thanrequest.ip
. This is because the buyer can be behind a proxy server. The proxies usually set HTTP_CLIENT_IP and/or HTTP_X_FORWARDED_FOR headers to track the originating client IP. These headers are properly handled byrequest.remote_ip
(doc). The developer can optionally introduce a set of known proxy servers to further control this behaviour by settingRails.application.config.action_dispatch.trusted_proxies
.Checklist: