This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Add an acceptance test that ensures that the installation of extensio… #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
commented
Sep 17, 2021
| Then("I have the right binary for my system's architecture") do | ||
| system_architecture = `uname -m` | ||
| binary_architecture = `file #{File.expand_path("shopify-extensions", @working_dir)}` | ||
| assert binary_architecture.include?(system_architecture) |
There was a problem hiding this comment.
Not 100% this works in environment others than macOS but I'll let CI tests surface any incompatibilities :)
t6d
force-pushed
the
feature/download-shopify-cli-extensions-during-installation
branch
2 times, most recently
from
7f224a5 to
0f98a82
Compare
Base automatically changed from
feature/download-shopify-cli-extensions-during-installation
to
main
September 17, 2021 20:25
Co-authored-by: Trish Ta <[email protected]>
Co-authored-by: Trish Ta <[email protected]>
pepicrft
force-pushed
the
pull-cli-extension-acceptance-test
branch
from
1ecc971 to
399ad12
Compare
… to run on Linux environments
cecyc
pushed a commit
that referenced
this pull request
Sep 20, 2021
Add an acceptance test that ensures that the installation of extensio…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This PR extends this PR to add an acceptance test that ensures that the installation of Shopify Extensions doesn't break.
WHAT is this pull request doing?
Add an acceptance test that ensures the installation of extensions works.
Update checklist