Decimal implements Deref #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
|
FYI: Some new guidance on |
jbourassa
approved these changes
Mar 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Dereffor Decimal, to remove the need to write.as_f64/.0to access the inner value and its functions.The original PR for decimals mentions (#34 (comment)) not implementing it based on rust docs guidance. At the moment, the rust community is still trying to define what a smart pointer is (rust-lang/rust#91004).
In my use case, I commonly just need to just work with the inner value of Decimal, without really caring about the wrapper, which results in a lot of .0 or .as_f64. I'd figure other developers might be in the same boat. I do not see any real downside with implementing
Derefin this instance.