Update ngrok template #1098
Merged
Update ngrok template #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjoyal
commented
Oct 19, 2020
| @@ -90,7 +90,7 @@ class InstallGeneratorTest < Rails::Generators::TestCase | |||
| test "adds host config to development.rb" do | |||
| run_generator | |||
| assert_file "config/environments/development.rb" do |config| | |||
| assert_match "config.hosts = (config.hosts rescue []) << /\\h+.ngrok.io/", config | |||
| assert_match "config.hosts = (config.hosts rescue []) << /\\w+\\.ngrok\\.io/", config | |||
There was a problem hiding this comment.
Would it be easier to read if the test was like that?
assert_match 'config.hosts = (config.hosts rescue []) << /\w+\.ngrok\.io/', config
There was a problem hiding this comment.
Looks the same to me, I think it's fine as is.
paulomarg
approved these changes
Oct 20, 2020
tanema
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added here: #802
It took me a long while to understand that \h in ruby is not the same as some other languages.....
That being said, paid ngrok account and use more characters in their premium domains.
Also adding some
\.to make sure we treat them as dots and not wildcards.