Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: lock app-bridge to < 2 for this minor release #1238

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

NabeelAhsen
Copy link
Contributor

What this PR does

With App Bridge 2.0, we need to lock all existing (for this minor release) app developers to app-bridge@1 using the CDN. By default, CDN will serve app bridge 2.0, which is breaking.

Reviewer's guide to testing

  • Tophat this by creating a new app (or using an existing app) and ensure you don't get served app-bridge 2.0 in the embedded_app layout

Things to focus on

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@NabeelAhsen NabeelAhsen self-assigned this Apr 1, 2021
@NabeelAhsen NabeelAhsen force-pushed the hot-fix-hardcode-app-bridge-version branch from f0401e8 to ca5b39c Compare April 1, 2021 17:41
Copy link
Contributor

@rezaansyed rezaansyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a patch release as it fixes a bug.

@NabeelAhsen NabeelAhsen merged commit b66db78 into master Apr 1, 2021
@NabeelAhsen NabeelAhsen deleted the hot-fix-hardcode-app-bridge-version branch April 1, 2021 18:15
@NabeelAhsen NabeelAhsen mentioned this pull request Apr 1, 2021
4 tasks
@NabeelAhsen NabeelAhsen temporarily deployed to rubygems April 1, 2021 19:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants