Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging for release 18.0.1 #1268

Merged
merged 4 commits into from
May 10, 2021
+9 −4
Merged

Packaging for release 18.0.1 #1268

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9dda13
Packaging for release 18.0.1
jesalerno84 May 7, 2021
88bbcfb
added 4Troubleshooting note for 401s during oauth
jesalerno84 May 7, 2021
cd82790
added link to more info on the 401 race condition
jesalerno84 May 7, 2021
bc075f2
reverted graphql version back to 1.12.8
jesalerno84 May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Unreleased
18.0.1 (May 7, 2021)
----------
* Fix bug causing OAuth flow to fail due to CSP violation. [#1265](https://github.com/Shopify/shopify_app/pull/1265)

Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
shopify_app (18.0.0)
shopify_app (18.0.1)
browser_sniffer (~> 1.2.2)
jwt (>= 2.2.3)
omniauth-rails_csrf_protection
Expand Down Expand Up @@ -105,7 +105,7 @@ GEM
faraday-net_http_persistent (1.1.0)
globalid (0.4.2)
activesupport (>= 4.2.0)
graphql (1.12.8)
graphql (1.12.9)
greatestape marked this conversation as resolved.
Show resolved Hide resolved
graphql-client (0.16.0)
activesupport (>= 3.0)
graphql (~> 1.8)
Expand Down
5 changes: 5 additions & 0 deletions docs/Troubleshooting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
[App installation](#app-installation)
* [My app won't install](#my-app-wont-install)
* [My app keeps redirecting to login](#my-app-keeps-redirecting-to-login)
* [My app returns 401 during oauth](#my-app-returns-401-during-oauth)

[JWT session tokens](#jwt-session-tokens)
* [My app is still using cookies to authenticate](#my-app-is-still-using-cookies-to-authenticate)
Expand Down Expand Up @@ -67,6 +68,10 @@ Alternatively, you can upgrade to [`v17.2.0` of the shopify_app gem](/docs/Upgra

This issue can occur when the session (the model you set as `ShopifyApp::SessionRepository.storage`) isn't deleted when the user uninstalls your app. A possible fix for this is listening to the `app/uninstalled` webhook and deleting the corresponding session in the webhook handler.

### My app returns 401 during oauth

If your local dev env uses the `cookie_store` session storage strategy, you may encounter 401 errors during oauth due to a race condition between asset requests and `/auth/shopify`. You should be able to work around for local testing by using a different browser or session storage strategy. [Read more about the status of this issue](https://github.com/Shopify/shopify_app/issues/1269).

## JWT session tokens

### My app is still using cookies to authenticate
Expand Down
2 changes: 1 addition & 1 deletion lib/shopify_app/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# frozen_string_literal: true
module ShopifyApp
VERSION = '18.0.0'
VERSION = '18.0.1'
end
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "shopify_app",
"version": "18.0.0",
"version": "18.0.1",
"repository": "[email protected]:Shopify/shopify_app.git",
"author": "Shopify",
"license": "MIT",
Expand Down