Support Rails 7 #1354
Merged
Support Rails 7 #1354
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaloriestra
commented
Jan 26, 2022
| @@ -9,6 +9,10 @@ | |||
| /> | |||
| <% unless with_cookie_authentication? %> <script> | |||
| document.addEventListener("DOMContentLoaded", async function() { | |||
| <% if ShopifyApp.use_importmap? %> | |||
| await import("lib/shopify_app") | |||
There was a problem hiding this comment.
Is this the best way to load shopify_app.js? It requires the DOM content to be loaded, but we need to run it before this point.
There was a problem hiding this comment.
Both, await and import are supported by most of the browsers so I'd say it's fine.
pepicrft
approved these changes
Jan 27, 2022
| @@ -9,6 +9,10 @@ | |||
| /> | |||
| <% unless with_cookie_authentication? %> <script> | |||
| document.addEventListener("DOMContentLoaded", async function() { | |||
| <% if ShopifyApp.use_importmap? %> | |||
| await import("lib/shopify_app") | |||
There was a problem hiding this comment.
Both, await and import are supported by most of the browsers so I'd say it's fine.
Closed
4 tasks
|
Amazing update! 👍🔥 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1339
What this PR does
Reviewer's guide to testing
rails -vrails new my_appbundle add shopify_app --git 'git://github.com/Shopify/shopify_app.git' --branch 'rails-7'rails generate shopify_apprails db:migratengrok http 3000and copy the HTTPS URL/auth/shopify/callbackin theAllowed redirection URLsfieldSHOPIFY_API_KEY=x SHOPIFY_API_SECRET=y rails serverChecklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary