Ignore extra kwargs on perform()
in WebhooksManagerJob
#1466
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This changes the
perform()
method ofWebhooksManagerJob
to accept-and-ignore additional keyword arguments.One of the things we noticed during upgrade from v18 to >=v19 is that https://github.com/Shopify/shopify_app/blob/main/lib/shopify_app/jobs/webhooks_manager_job.rb#L9 used to take a webhooks parameter to the function, but no longer does. This manifests in errors where webhooks that have been registered with Core pre-upgrade include that parameter on delivery, and so error out.
I plan on porting this fix to v19.1 branch and v20 branch along with
main
, since I think it's a useful change and removes a gotcha for upgrades.Reviewer's guide to testing
app/uninstalled
handler;app/uninstalled
webhooks are registered!)Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary