Pass access scopes on query string #1540
Merged
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Oct 19, 2022
| @@ -167,6 +167,10 @@ def login_url_params(top_level:) | |||
| query_params[:host] ||= host | |||
| end | |||
|
|
|||
| if params[:access_scopes].present? | |||
| query_params[:scope] = params[:access_scopes].join(",") | |||
There was a problem hiding this comment.
Other places in this method use ||= but I don't see a need for that here.
There was a problem hiding this comment.
Makes sense to me, if we get query args we should override them, assuming we can trust the source - is this secured in any way, like with an HMAC?
There was a problem hiding this comment.
(Discussed internally, we do not see any issue here)
5 tasks
andyw8
force-pushed
the
andyw8/pass-access-scopes-on-query-string
branch
2 times, most recently
from
3067bc1 to
419ac14
Compare
andyw8
force-pushed
the
andyw8/pass-access-scopes-on-query-string
branch
3 times, most recently
from
03c41da to
0cc7769
Compare
andyw8
force-pushed
the
andyw8/pass-access-scopes-on-query-string
branch
from
0cc7769 to
e2d065d
Compare
andyw8
commented
Oct 25, 2022
| 21.1.1 (Oct 20, 2022) | ||
| ---------- | ||
| * Updates dependency to `shopify_api` to 12.2 to fix error with host_name argument. | ||
|
|
||
| 21.1.0 (Oct 17, 2022) | ||
| ---------- | ||
|
|
There was a problem hiding this comment.
Removed these for consistency.
paulomarg
approved these changes
Oct 25, 2022
| @@ -167,6 +167,10 @@ def login_url_params(top_level:) | |||
| query_params[:host] ||= host | |||
| end | |||
|
|
|||
| if params[:access_scopes].present? | |||
| query_params[:scope] = params[:access_scopes].join(",") | |||
There was a problem hiding this comment.
Makes sense to me, if we get query args we should override them, assuming we can trust the source - is this secured in any way, like with an HMAC?
nelsonwittwer
approved these changes
Oct 25, 2022
|
/shipit |
fabriazza
pushed a commit
to fabriazza/shopify_app
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Andy Waite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
See explanation in related PR: Shopify/shopify-api-ruby#1023
Reviewer's guide to testing
Use dev version of https://shopify-graphiql-app.shopifycloud.com/
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersUpdateREADME.md, if appropriate.Update any relevant pages in/docs, if necessaryFor security fixes, the Disclosure Policy must be followed.