Remove Itp from LoginProtection
#1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonwittwer
requested changes
Dec 8, 2022
klenotiw
commented
Dec 8, 2022
| If any of your controllers are dependant on methods from `Itp` then you can include `ShopifyApp::Itp` directly. | ||
| You may notice a deprecation notice saying, `Itp will be removed in an upcoming version`. | ||
| This is because we intend on removing `Itp` completely in `v22.0.0`, but this will work in the meantime. | ||
|
|
There was a problem hiding this comment.
I hope this is the right place?
I was also thinking of adding the names of the methods like set_test_cookie, set_top_level_oauth_cookie, clear_top_level_oauth_cookie, ....
So it would be easy to search for that method being removed in the upgrading doc. How do you feel about that?
klenotiw
commented
Dec 8, 2022
ooops sorry about missing this, I've been so scatterbrained lately |
Co-authored-by: Nelson <[email protected]>
Co-authored-by: Nelson <[email protected]>
nelsonwittwer
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Itp's deprecation logs were getting sent when loadingLoginProtection.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary