Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set access_scopes column to string by default #1636

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Set access_scopes column to string by default #1636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17fe03e
Set access_scopes column to string by default
kirillplatonov Jan 6, 2023
43930bb
Merge branch 'main' into access-scope-defaults
nelsonwittwer Jan 30, 2023
2f603ae
Merge branch 'main' into access-scope-defaults
kirillplatonov Mar 20, 2023
f702eb2
Merge branch 'main' into access-scope-defaults
nelsonwittwer Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Unreleased
----------

* Set `access_scopes` column to string by default [#1636](https://github.com/Shopify/shopify_app/pull/1636)

21.4.0 (Jan 5, 2023)
----------
* Updated shopify_api to 12.4.0 [#1633](https://github.com/Shopify/shopify_app/pull/1633)
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/shopify_app/shop_model/templates/db/migrate/add_shop_access_scopes_column.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class AddShopAccessScopesColumn < ActiveRecord::Migration[<%= rails_migration_version %>]
def change
add_column :shops, :access_scopes, :string
add_column :shops, :access_scopes, :string, default: "", null: false
end
end
2 changes: 1 addition & 1 deletion lib/generators/shopify_app/user_model/templates/db/migrate/add_user_access_scopes_column.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class AddUserAccessScopesColumn < ActiveRecord::Migration[<%= rails_migration_version %>]
def change
add_column :users, :access_scopes, :string
add_column :users, :access_scopes, :string, default: "", null: false
end
end