Fix and Refactor splash page URL Handling to Respect Nested URLs #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uurcank
changed the title
paulomarg
reviewed
Feb 20, 2024
paulomarg
added
the
Waiting for Response
|
@paulomarg ready for merge 👍 |
github-actions
bot
removed
the
Waiting for Response
paulomarg
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an inconsistency in the splash_page_with_params method within the controller concern, where the method previously defaulted to the application's root path, disregarding the nested URL setting as explained here.
Previously, when a nested_url was enabled and the app was accessed from the Shopify dashboard or the page was refreshed, the user was incorrectly redirected back to the app's root URL, instead of the intended Shopify app root (the nested URL).