Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependency to latest major version of the API #1801

Merged
merged 9 commits into from
Mar 5, 2024

Conversation

nelsonwittwer
Copy link
Contributor

@nelsonwittwer nelsonwittwer commented Mar 5, 2024

What this PR does

Bumps the dependency on the shopify_api gem to the latest major version that was recently released. For those looking to install the latest version of the version of the ruby API there was a bundler dependency error as documented in shopify_app #1284

This also follows the direction of the API gem and requires Ruby 3.0 or greater as 2.7 is no longer supported.

Reviewer's guide to testing

To verify this worked as expected I used one of my test apps and installed the latest version of the API and pointed to this local branch:

gem "shopify_api", "~> 14.0"
gem "shopify_app", path: "../../shopify_app"

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@nelsonwittwer nelsonwittwer requested a review from a team as a code owner March 5, 2024 15:20
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one nit, but makes sense to me.

CHANGELOG.md Outdated Show resolved Hide resolved
@nelsonwittwer nelsonwittwer merged commit f5aaf8c into main Mar 5, 2024
7 checks passed
@nelsonwittwer nelsonwittwer deleted the nw/bump_api_dependency branch March 5, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants