Post authentication tasks after token exchange #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzooeeyy
force-pushed
the
token-exchange-post-auth-tasks
branch
from
1c198c5 to
dd66074
Compare
paulomarg
reviewed
Apr 2, 2024
| shop: domain, # TODO: use jwt_shopify_domain ? | ||
| session_token: session_token, | ||
| requested_token_type: ShopifyAPI::Auth::TokenExchange::RequestedTokenType::ONLINE_ACCESS_TOKEN, | ||
| ) | ||
| end | ||
|
|
||
| # TODO: Refactor and add post authenticate tasks | ||
| # ShopifyApp.configuration.post_authenticate_tasks.perform(session) if session | ||
| ShopifyApp.configuration.post_authenticate_tasks.perform(session) if session |
There was a problem hiding this comment.
If there isn't a session here, should we fail somehow?
There was a problem hiding this comment.
Hmm yea you're right, but I think that's already handled in the shopify-api-ruby layer --
We raise if there's any HttpResponseError in the TokenExchange method, and I don't think it'll go beyond that point if there's any errors in token exchange call. So we could probably just let the exception raise and assume session will be there if no exceptions were raised..
paulomarg
approved these changes
Apr 3, 2024
zzooeeyy
force-pushed
the
token-exchange-post-auth-tasks
branch
from
6d24584 to
5defd48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Top hatting
PostAuthenticateTask methods are called after token exchange completes
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary