Disable mixin tracking when we do includes for probing #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We do dynamic includes of any module that we encounter into an empty anonymous class, so that we can discover side effects of doing such includes. This is how
DynamicMixinCompilerworks. However, that means that our mixin tracker attributes those includes as mixin locations that it needs to consider, which is wrong.Implementation
Added a means to disable mixin registration during certain blocks where we know that we should not record mixins, and used that in the main block of
DynamicMixinCompiler.Tests
Added a test that fails if we have not disabled mixin recording during
DynamicMixinCompileroperation.