Add original gem source location to RBIs #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Jun 30, 2022
Morriar
reviewed
Jun 30, 2022
Morriar
approved these changes
Jun 30, 2022
Morriar
reviewed
Jun 30, 2022
vinistock
force-pushed
the
group-pairing-go-to-def
branch
from
0dd0a48 to
0de643f
Compare
Morriar
approved these changes
Jun 30, 2022
paracycle
reviewed
Jun 30, 2022
paracycle
reviewed
Jul 4, 2022
vinistock
force-pushed
the
group-pairing-go-to-def
branch
2 times, most recently
from
9e6b260 to
4d483af
Compare
paracycle
reviewed
Jul 6, 2022
vinistock
force-pushed
the
group-pairing-go-to-def
branch
from
4d483af to
64a2a9a
Compare
egiurleo
approved these changes
Jul 7, 2022
vinistock
force-pushed
the
group-pairing-go-to-def
branch
from
64a2a9a to
7f71017
Compare
Morriar
approved these changes
Jul 7, 2022
Co-authored-by: Alexandre Terrasa <[email protected]> Co-authored-by: Rafael França <[email protected]> Co-authored-by: Ryan Brushett <[email protected]> Co-authored-by: Kaan Ozkan <[email protected]> Co-authored-by: Stan Lo <[email protected]> Co-authored-by: Maple Ong <[email protected]> Co-authored-by: Adison Lampert <[email protected]>
vinistock
force-pushed
the
group-pairing-go-to-def
branch
from
7f71017 to
de74e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tapioca knows the original location of where methods, classes and modules were defined while generating the RBIs. By including this information as comments, we can enable go to gem source using the Ruby LSP quite easily.
Implementation
The first commit adds the original method and passes it around the pipeline. The second commit creates a new listener that decorates all nodes with the original location information using the format
source://GEM_NAME-GEM_VERSION/path/to/file.We can use the
DocumentLinkrequest to connect these special URIs to the proper file system path and enable go to def.Tests
Added tests.