ActiveModel DateTime Attribute is a Time, not a DateTime #1036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
From what I can tell, both:
ActiveModel attributes that are a
ActiveModel::Type::DateTime
or aActiveModel::Type::Time
end up as a ruby::Time
, not a ruby::DateTime
.Implementation
Small change to use
::Time
rather than::DateTime
Tests
I updated the existing test for the ActiveModel compiler