Make --workers option not experimental
#1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
reviewed
Jul 19, 2022
README.md
Outdated
| @@ -156,8 +156,7 @@ Options: | |||
| # Default: true | |||
| [--exported-gem-rbis], [--no-exported-gem-rbis] # Include RBIs found in the `rbi/` directory of the gem | |||
| # Default: true | |||
| -w, [--workers=N] # EXPERIMENTAL: Number of parallel workers to use when generating RBIs | |||
| # Default: 1 | |||
| -w, [--workers=N] # Number of parallel workers to use when generating RBIs | |||
There was a problem hiding this comment.
Should we explain that by default it will use logic from the parallel gem to detect how many processors to use? I'm guessing some people will wrongly assume the default is 1 worker?
There was a problem hiding this comment.
I added (default: auto) in the description, lmkwys 👍
Signed-off-by: Alexandre Terrasa <[email protected]>
vinistock
approved these changes
Jul 20, 2022
paracycle
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently if no
--workersoption is pass, we'll fallback to1by default.This is a problem as we can't use
parallelmechanism to auto-detect how many processors to use. By passingnilby default Tapioca will use has many processors as available by default.This means making the parallel execution not experimental anymore (as it becomes the default behavior) but people can still disable it manually by passing
--workers 1.