Report Rails load errors and continue generating #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/tapioca/loaders/loader.rb
Outdated
| end | ||
|
|
||
| eager_load_rails_app if eager_load | ||
| rescue LoadError => e | ||
| say("Tapioca attempted to load the Rails application after encountering a `config/application.rb` file," \ |
There was a problem hiding this comment.
Would not this only happen when the file isn't found? I think that would be the only cause for a LoadError.
There was a problem hiding this comment.
What do you think about catching all kinds of errors and showing them in the output rather than just LoadError?
There was a problem hiding this comment.
👍 Modified to rescue StandardError as well as LoadError
KaanOzkan
force-pushed
the
ko/report-rails-load-error
branch
3 times, most recently
from
48030f9 to
cd3fd05
Compare
rafaelfranca
approved these changes
Aug 9, 2022
paracycle
approved these changes
Aug 9, 2022
KaanOzkan
force-pushed
the
ko/report-rails-load-error
branch
from
cd3fd05 to
6846710
Compare
KaanOzkan
commented
Aug 10, 2022
| @@ -1758,5 +1758,40 @@ def title=(title); end | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe "cli::dsl::custom application.rb" do | |||
There was a problem hiding this comment.
The application.rb change was leaking to other tests so I moved it to a new top level describe block.
Other solutions could be changing this to use before_each or to write the original application.rb back at the end.
paracycle
pushed a commit
that referenced
this pull request
Aug 22, 2022
Report Rails load errors and continue generating
paracycle
pushed a commit
that referenced
this pull request
Aug 22, 2022
Report Rails load errors and continue generating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #1080
Implementation
Rescue exceptions thrown during eager loading of the rails application
Tests
Added a test