Fix failures against Rails main
#1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Aug 10, 2022
paracycle
force-pushed
the
uk-fix-rails-main-builds
branch
from
ab6e466 to
8f43438
Compare
|
CI for all other Rails versions is now broken. |
paracycle
force-pushed
the
uk-fix-rails-main-builds
branch
from
8f43438 to
0414b78
Compare
|
@rafaelfranca Thanks, I missed that the block adding |
`xxx_confirmation` and `xxx_challenge` attributes are added post-Rail 7 Upstream PR: rails/rails#43688
We still need to set the field so that older Rails versions do not keep showing deprecation warnings like: ``` DEPRECATION WARNING: Using legacy connection handling is deprecated. Please set `legacy_connection_handling` to `false` in your application. The new connection handling does not support `connection_handlers` getter and setter. Read more about how to migrate at: https://guides.rubyonrails.org/active_record_multiple_databases.html#migrate-to-the-new-connection-handling ``` Upstream removal PR: https://github.com/rails/rails/pull/44827/files
Upstream PR: rails/rails#37944
Fixtures no longer eagerly define methods, but instead rely on `method_missing` to handle fixture methods lazily. Thus, the implementation needs to change to lookup fixture names in the new `fixture_sets` class attribute. Upstream PR: rails/rails#44528
paracycle
force-pushed
the
uk-fix-rails-main-builds
branch
from
0414b78 to
53d3583
Compare
rafaelfranca
approved these changes
Aug 10, 2022
paracycle
added a commit
that referenced
this pull request
Aug 22, 2022
Fix failures against Rails `main`
paracycle
added a commit
that referenced
this pull request
Aug 22, 2022
Fix failures against Rails `main`
paracycle
added a commit
that referenced
this pull request
Aug 22, 2022
Fix failures against Rails `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our builds against Rails
mainhave been failing, so this PR attempts to address all the changes since Rails 7.Implementation
Each commit explains what was changed with a link to upstream change that made it necessary.
Tests
No additional tests