Start matching pathname directory prefixes more rigorously #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-fix-directory-comparison
branch
from
e5fdc2a to
691e369
Compare
rafaelfranca
approved these changes
Sep 16, 2022
Fixes #1174 The simplistic `start_with?` check was not sufficient to match that a given file/folder was under a given folder, since we were not explicitly checking for full folder name matches. For example, if `path = "/foo/bar-gem/baz"` and `folder = "/foo/bar"`, then `path.start_with?(folder)` would return `true`, but `path` is not under the `folder` directory. This commit fixes the problem by matching `folder` to any of the parent directories of `path` by using the `Pathname#ascend` method to get all parent directory prefixes of a `path`.
paracycle
force-pushed
the
uk-fix-directory-comparison
branch
from
691e369 to
1a68dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1174
Motivation
The simplistic
start_with?check was not sufficient to match that a given file/folder was under a given folder, since we were not explicitly checking for full folder name matches. For example, ifpath = "/foo/bar-gem/baz"andfolder = "/foo/bar", thenpath.start_with?(folder)would returntrue, butpathis not under thefolderdirectory.Implementation
This commit fixes the problem by matching
folderto any of the parent directories ofpathby using thePathname#ascendmethod to get all parent directory prefixes of apath.Tests
Added a test that fails without the fix.