Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error and fail early for unknown options #1208

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Show error and fail early for unknown options #1208

merged 1 commit into from
Oct 4, 2022

Conversation

paracycle
Copy link
Member

Motivation

Fixes #1172

Implementation

Use the check_unknown_options! method on Thor::Base to enforce option correctness.

Tests

Added a CLI test to the DSL spec.

@paracycle paracycle added the enhancement New feature or request label Oct 3, 2022
@paracycle paracycle requested a review from a team as a code owner October 3, 2022 22:29
@paracycle paracycle merged commit 8a89d06 into main Oct 4, 2022
@paracycle paracycle deleted the uk-unknown-options branch October 4, 2022 15:52
@shopify-shipit shopify-shipit bot temporarily deployed to production November 10, 2022 17:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usability improvement: tell users when they use an invalid flag
3 participants
@paracycle @st0012 @egiurleo