Start testing against Ruby 3.2 #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the default `experimental` entry in the build matrix, and instead mark Ruby versions and/or gemfiles that are experimental as `true` in the `include` section. This works really well, since the default value for `experimental` is `false`, which is basically the same as `undefined`, so it doesn't need to be declared explicitly. I made sure that the `continue-on-error` is properly assigned a boolean value by using the `!!` operator, to be safe. As for the `includes` section, the documentation states that: > the key:value pairs in the object will be added to each of the matrix combinations if none of the key:value pairs overwrite any of the original matrix values. This means that if we add `experimental: true` for a specific matrix item, then that will be added to all the matrix entries that match that matrix item. Using this, we can mark all matrix entries that use `Gemfile-rails-main` gemfile as being experimental, without having to enumerate all the Ruby versions again.
rafaelfranca
approved these changes
Oct 6, 2022
st0012
reviewed
Oct 6, 2022
| gemfile: | ||
| - Gemfile | ||
| - gemfiles/Gemfile-rails-6-1 | ||
| - gemfiles/Gemfile-rails-main | ||
| include: | ||
| - gemfile: gemfiles/Gemfile-rails-main |
There was a problem hiding this comment.
Now we add gemfiles/Gemfile-rails-main to the matrix, is this still needed?
Does it mark all gemfiles/Gemfile-rails-main as experimental?
There was a problem hiding this comment.
Does it mark all
gemfiles/Gemfile-rails-mainas experimental?
Yes, exactly this. The documentation states:
For each object in the include list, the key:value pairs in the object will be added to each of the matrix combinations if none of the key:value pairs overwrite any of the original matrix values.
So adding gemfiles/Gemfile-rails-main here with experimental: true marks all those gemfile builds to be experimental, which was what we were doing before by enumerating them explicitly.
st0012
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should make sure Tapioca works well against upcoming Ruby 3.2 version
Implementation
I simplified the way we declare
experimentalbuilds and addedruby: "3.2"target and marked itexperimental.Tests
No new tests.