Drop pry as a runtime dependency
#1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-drop-pry
branch
from
73327cf to
e948886
Compare
vinistock
reviewed
Nov 2, 2022
paracycle
force-pushed
the
uk-drop-pry
branch
from
e948886 to
0f0d41a
Compare
Add relevant machinery inside the `Reflection` class to discover file candidates for a given constant based on the source location of the given constant's (or its singleton class') methods.
paracycle
force-pushed
the
uk-drop-pry
branch
from
0f0d41a to
22e983d
Compare
vinistock
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been using
pryas a runtime dependency only because it was convenient to use itsPry::WrappedModulefunctionality to figure out which files a constant might be defined in.However, that's actually a very minimal amount of logic that we've been relying on and the runtime dependency on a development tool has always been a bit weird. It is about time we stop doing that.
Implementation
I mostly adapted the code from https://github.com/pry/pry/blob/master/lib/pry/wrapped_module.rb#L296-L368 into our
Reflectionclass.Tests
No added tests, existing tests should continue to run properly.