Refactor DSL compiler options to be a flat namespaced hash and document them #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
approved these changes
Jun 18, 2024
Morriar
reviewed
Jun 18, 2024
I've been thinking about this for a while, and I think namespacing compiler options was a little heavy handed. I've been thinking about cases where a single option might need to be consumed by multiple Active Record compilers, so I think it makes sense to have a flat hash of options that can be consumed by any compiler. This makes the code simpler and makes it easier to pass these options on the command line interface, as well.
paracycle
force-pushed
the
uk-refactor-dsl-options
branch
from
8ae3d80 to
2597e5b
Compare
paracycle
force-pushed
the
uk-refactor-dsl-options
branch
from
2597e5b to
4c458b6
Compare
Morriar
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking about this for a while, and I think namespacing compiler options was a little heavy handed. I've been thinking about cases where a single option might need to be consumed by multiple Active Record compilers, so I think it makes more sense to have a flat hash of options that can be consumed by any compiler.
This makes the code simpler and makes it easier to pass these options on the command line interface, as well.
I've also used this opportunity to improve the documentation, as promised