Bump the minor-and-patch group with 4 updates #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the minor-and-patch group with 4 updates: [irb](https://github.com/ruby/irb), [rubocop-rspec](https://github.com/rubocop/rubocop-rspec), [identity_cache](https://github.com/Shopify/identity_cache) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). Updates `irb` from 1.13.2 to 1.14.0 - [Release notes](https://github.com/ruby/irb/releases) - [Commits](ruby/irb@v1.13.2...v1.14.0) Updates `rubocop-rspec` from 3.0.1 to 3.0.2 - [Release notes](https://github.com/rubocop/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rspec@v3.0.1...v3.0.2) Updates `identity_cache` from 1.5.6 to 1.6.0 - [Changelog](https://github.com/Shopify/identity_cache/blob/main/CHANGELOG.md) - [Commits](Shopify/identity_cache@v1.5.6...v1.6.0) Updates `sorbet-static-and-runtime` from 0.5.11463 to 0.5.11473 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: irb dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: rubocop-rspec dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: identity_cache dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: sorbet-static-and-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
andyw8
force-pushed
the
dependabot/bundler/minor-and-patch-584dbfb7ce
branch
from
dd7260b to
7e05efe
Compare
andyw8
approved these changes
Jul 9, 2024
amomchilov
approved these changes
Jul 10, 2024
lib/tapioca/dsl/compiler.rb
Outdated
| @@ -49,15 +49,15 @@ def processable_constants | |||
| sig { returns(T::Enumerable[T::Class[T.anything]]) } | |||
| def all_classes | |||
| @all_classes ||= T.let( | |||
| T.cast(ObjectSpace.each_object(Class), T::Enumerable[T::Class[T.anything]]).each, | |||
| ObjectSpace.each_object(Class).each, | |||
There was a problem hiding this comment.
Unrelated to the change, but does this .each even do anything? ObjectSpace.each_object(Class) is already an T::Enumerable[T::Class[T.anything]]
There was a problem hiding this comment.
Yeah, seems unnecessary:
irb(main):002> ObjectSpace.each_object(Module).count
=> 773
irb(main):003> ObjectSpace.each_object(Module).each.count
=> 773
There was a problem hiding this comment.
Nitpick: the result is an enumerator not an enumerable, when no block is given.
lib/tapioca/runtime/reflection.rb
Outdated
| @@ -166,7 +166,7 @@ def method_of(constant, method) | |||
| end | |||
| def descendants_of(klass) | |||
| result = ObjectSpace.each_object(klass.singleton_class).reject do |k| | |||
| T.cast(k, Module).singleton_class? || T.unsafe(k) == klass | |||
| k.singleton_class? || T.unsafe(k) == klass | |||
There was a problem hiding this comment.
Can remove the unsafe if we flip this and make the receiver be the klass:
Suggested change
| k.singleton_class? || T.unsafe(k) == klass | |
| k.singleton_class? || klass == k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the minor-and-patch group with 4 updates: irb, rubocop-rspec, identity_cache and sorbet-static-and-runtime.
Updates
irbfrom 1.13.2 to 1.14.0Release notes
Sourced from irb's releases.
Commits
6a9e129Bump version to v1.14.0 (#980)7b6557cReturn only commands when completing help command's argument (#973)4a0e0e8Introduce cd command (#971)00603d4Allow assigning and using local variable name conflicting with command (#961)c844176Improve how command calls' return value is handled (#972)Updates
rubocop-rspecfrom 3.0.1 to 3.0.2Release notes
Sourced from rubocop-rspec's releases.
Changelog
Sourced from rubocop-rspec's changelog.
Commits
77f026bMerge pull request #1933 from rubocop/release0cb5dc5Release v3.0.29ca2541Merge pull request #1931 from jeppester/master4c2e03eBetter assist rspec rails cop users when migrating to 311f5cb8Merge pull request #1930 from Earlopain/false-negative-predicate-matcher7586bc3Fix false negative forRSpec/PredicateMatcherwhen expectation contains cus...781a866Merge pull request #1927 from bmulholland/patch-15646c8cApply suggestions from code review5fd1228chore(docs): Gem names and troubleshooting for v3 migration instructions2004e4bMerge pull request #1924 from rubocop/add-tocUpdates
identity_cachefrom 1.5.6 to 1.6.0Changelog
Sourced from identity_cache's changelog.
Commits
5ae647aIntroduce Deferred Parent Cache Expiry (#569)494ac2aBump rexml from 3.2.6 to 3.2.8 in the bundler group across 1 directory (#567)313dfbcBump dalli from 2.7.11 to 3.2.3 (#564)Updates
sorbet-static-and-runtimefrom 0.5.11463 to 0.5.11473Release notes
Sourced from sorbet-static-and-runtime's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions