Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tapioca add-on] Add add-on boiler plate #2030

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

vinistock
Copy link
Member

Motivation

Create the add-on boiler plate with basic activation and getting a handle to the Rails add-on's runtime client.

Implementation

This is just boiler plate code for the basic add-on.

Tests

We are discussing how to test the add-on. Due to the dependency on the Rails add-on, it fails to activate without a Rails app, so we may need to add a dummy one. We can also explore stubbing to see if we can avoid that.

@vinistock vinistock added the enhancement New feature or request label Oct 3, 2024
@vinistock vinistock self-assigned this Oct 3, 2024
@vinistock vinistock requested a review from a team as a code owner October 3, 2024 18:22
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to add a single-file Rails application into the repo somewhere, right? It doesn't have to be an app with the normal Rails structure and stuff.

@vinistock
Copy link
Member Author

We should be able to add a single-file Rails application into the repo somewhere, right? It doesn't have to be an app with the normal Rails structure and stuff.

That is true, if we can have just enough to boot the runtime server, that should be enough for the tests.

@vinistock vinistock merged commit f567a16 into tapioca-addon-feature-branch Oct 3, 2024
30 checks passed
@vinistock vinistock deleted the vs-add-on branch October 3, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants