Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRecord select block returns BasicObject #2147

Merged
merged 1 commit into from
Jan 9, 2025
Merged

ActiveRecord select block returns BasicObject #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tapioca/dsl/compilers/active_record_relations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ def create_relation_methods
sig.return_type = mod == relation_methods_module ? RelationClassName : AssociationRelationClassName
end
method.add_sig do |sig|
sig.add_param("blk", "T.proc.params(record: #{constant_name}).returns(T::Boolean)")
sig.add_param("blk", "T.proc.params(record: #{constant_name}).returns(BasicObject)")
sig.return_type = "T::Array[#{constant_name}]"
end
end
Expand Down
8 changes: 4 additions & 4 deletions spec/tapioca/dsl/compilers/active_record_relations_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ def reverse_order(*args, &blk); end
def rewhere(*args, &blk); end
sig { params(args: T.untyped).returns(PrivateAssociationRelation) }
sig { params(blk: T.proc.params(record: ::Post).returns(T::Boolean)).returns(T::Array[::Post]) }
sig { params(blk: T.proc.params(record: ::Post).returns(BasicObject)).returns(T::Array[::Post]) }
def select(*args, &blk); end
sig { params(args: T.untyped, blk: T.untyped).returns(PrivateAssociationRelation) }
Expand Down Expand Up @@ -594,7 +594,7 @@ def reverse_order(*args, &blk); end
def rewhere(*args, &blk); end
sig { params(args: T.untyped).returns(PrivateRelation) }
sig { params(blk: T.proc.params(record: ::Post).returns(T::Boolean)).returns(T::Array[::Post]) }
sig { params(blk: T.proc.params(record: ::Post).returns(BasicObject)).returns(T::Array[::Post]) }
def select(*args, &blk); end
sig { params(args: T.untyped, blk: T.untyped).returns(PrivateRelation) }
Expand Down Expand Up @@ -1159,7 +1159,7 @@ def reverse_order(*args, &blk); end
def rewhere(*args, &blk); end
sig { params(args: T.untyped).returns(PrivateAssociationRelation) }
sig { params(blk: T.proc.params(record: ::Post).returns(T::Boolean)).returns(T::Array[::Post]) }
sig { params(blk: T.proc.params(record: ::Post).returns(BasicObject)).returns(T::Array[::Post]) }
def select(*args, &blk); end
sig { params(args: T.untyped, blk: T.untyped).returns(PrivateAssociationRelation) }
Expand Down Expand Up @@ -1320,7 +1320,7 @@ def reverse_order(*args, &blk); end
def rewhere(*args, &blk); end
sig { params(args: T.untyped).returns(PrivateRelation) }
sig { params(blk: T.proc.params(record: ::Post).returns(T::Boolean)).returns(T::Array[::Post]) }
sig { params(blk: T.proc.params(record: ::Post).returns(BasicObject)).returns(T::Array[::Post]) }
def select(*args, &blk); end
sig { params(args: T.untyped, blk: T.untyped).returns(PrivateRelation) }
Expand Down
Loading