Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for for Rails 7.0 logger issue #2161

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jan 20, 2025

Closes #2158 (see rails/rails#54260)

@andyw8 andyw8 mentioned this pull request Jan 20, 2025
@andyw8 andyw8 added the chore label Jan 20, 2025
@andyw8 andyw8 marked this pull request as ready for review January 20, 2025 21:43
@andyw8 andyw8 requested a review from a team as a code owner January 20, 2025 21:43
@andyw8 andyw8 requested a review from KaanOzkan January 20, 2025 21:43
@andyw8 andyw8 force-pushed the andyw8/rails7.0-logger-workaround branch 2 times, most recently from 9bc15d8 to 44f68bd Compare January 21, 2025 13:42
@vinistock
Copy link
Member

Reading rails/rails#54260 (comment), it seems that it has already been fixed in Rails 7.1.

Could we just update Rails? What's our testing policy when it comes to Rails versions in Tapioca? If Rails 8 is already out, maybe we should be testing against 8 and 7.1?

@andyw8
Copy link
Contributor Author

andyw8 commented Jan 21, 2025

There's quite a few places that reference 7.0 or 7.1, how about we ship this to unblock main, then consider that separately? (I can log an issue).

@andyw8
Copy link
Contributor Author

andyw8 commented Jan 21, 2025

cc @KaanOzkan @paracycle

@vinistock
Copy link
Member

Sure, but in that case let's change the comments to reflect what we need to do. They are saying "once it's fixed", but this is already fixed we just haven't upgraded.

@paracycle
Copy link
Member

Yeah, I think we should drop 7.0 support at this point.

According to https://rubyonrails.org/maintenance the bug-fix supported versions of Rails is 8.0 and 7.2. We should move to testing on:

  • 7.2
  • current (meaning 8.0)
  • main

@andyw8 andyw8 force-pushed the andyw8/rails7.0-logger-workaround branch from 44f68bd to 1ce2039 Compare January 21, 2025 17:44
@andyw8
Copy link
Contributor Author

andyw8 commented Jan 21, 2025

Comment updated.

@andyw8 andyw8 merged commit 2564358 into main Jan 21, 2025
34 checks passed
@andyw8 andyw8 deleted the andyw8/rails7.0-logger-workaround branch January 21, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI errors on Rails 7.0
3 participants