-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for for Rails 7.0 logger issue #2161
Conversation
9bc15d8
to
44f68bd
Compare
Reading rails/rails#54260 (comment), it seems that it has already been fixed in Rails 7.1. Could we just update Rails? What's our testing policy when it comes to Rails versions in Tapioca? If Rails 8 is already out, maybe we should be testing against 8 and 7.1? |
There's quite a few places that reference 7.0 or 7.1, how about we ship this to unblock main, then consider that separately? (I can log an issue). |
Sure, but in that case let's change the comments to reflect what we need to do. They are saying "once it's fixed", but this is already fixed we just haven't upgraded. |
Yeah, I think we should drop 7.0 support at this point. According to https://rubyonrails.org/maintenance the bug-fix supported versions of Rails is 8.0 and 7.2. We should move to testing on:
|
44f68bd
to
1ce2039
Compare
Comment updated. |
Closes #2158 (see rails/rails#54260)