Add progress indication for DSL operations #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Trying on CodeDB... |
KaanOzkan
reviewed
Jan 29, 2025
vinistock
changed the base branch from
01-29-upgrade_rails_add-on_dependency_to_v0.4.0
to
graphite-base/2176
vinistock
force-pushed
the
01-28-add_progress_indication_for_dsl_operations
branch
from
d715e51 to
e0c3193
Compare
vinistock
force-pushed
the
01-28-add_progress_indication_for_dsl_operations
branch
from
e0c3193 to
b8d3c6f
Compare
vinistock
deleted the
01-28-add_progress_indication_for_dsl_operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes RBI generation can take a while and the user has no hints that anything is happening. This PR adds progress notifications, so that the user has visual hints that Tapioca is running when a file is saved.
Implementation
There's not much, I just wrapped our execution in the progress block.