Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymbolTableCompiler returns a new tree each time called #782

Merged
merged 1 commit into from
Feb 1, 2022
Merged

SymbolTableCompiler returns a new tree each time called #782

merged 1 commit into from
Feb 1, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Feb 1, 2022

Motivation

Those methods don't need to pass around the tree since the nodes are always created at the root level.

Tests

@Morriar Morriar added the chore label Feb 1, 2022
@Morriar Morriar requested a review from a team February 1, 2022 16:13
@Morriar Morriar self-assigned this Feb 1, 2022
@Morriar Morriar merged commit 15e49b4 into main Feb 1, 2022
@Morriar Morriar deleted the at-gem-tree branch February 1, 2022 21:38
@shopify-shipit shopify-shipit bot temporarily deployed to production February 17, 2022 22:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees

@Morriar Morriar

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @vinistock