Use RBI::Formatter #808
Merged
Use RBI::Formatter #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
force-pushed
the
at-rbi-formatter
branch
from
1a295b0 to
6cb739b
Compare
KaanOzkan
approved these changes
Feb 11, 2022
Morriar
force-pushed
the
at-rbi-formatter
branch
from
6cb739b to
136b7c7
Compare
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Morriar
force-pushed
the
at-rbi-formatter
branch
from
136b7c7 to
fc60963
Compare
vinistock
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Centralize the RBI formatting/printing options under a single class so it's easier to control the generated RBI from command line.
This PR adds an example with
--rbi-max-line-lengthto enforce wrapping for long signatures (see generated gem RBIs for example).Implementation
We create our own subclass of
RBI::Formatterto hold the default behaviour and the methods used to change the content of the generated RBI such aswrite_header!andwrite_empty_body_comments.Tests
See automated tests.
Please skip the two first commits as they belong to #807.